javascript - Using jquery to prepare jQuery UI tabs, optimize? -


codereview link: https://codereview.stackexchange.com/q/26006/24914

i looking review solution jquery dom manipulation exercise on appendto.com: http://learn.appendto.com/lesson/dom-manipulation-101#exercise

i'm wondering if there way can optimize or if there other aspects need consider when building solution this.

the problem outlined in fiddle: http://jsfiddle.net/khwzs/1283/

here solution:

var getfirsttwowords = function(str) {     return str.split(/\s+/).slice(1,3).join(" "); }  var tablinks = $("<ul></ul>"); $("div.tab").each( function( idx ) {     var id = "tabs-" + (idx + 1);      var text = $(this)         .removeclass("tab")         .attr("id", id)         .text();      var tablabel = getfirsttwowords(text);      // create corresponding tab link     tablinks.append("<li><a href=\"#" + id + "\">" + tablabel + "</a></li>");   });  $(".tabs div:first").before(tablinks); $( ".tabs" ).tabs();

optimized version:

var tablinks = $("<ul></ul>"); $("div.tab").each( function( idx ) {     var id = "tabs-" + (idx + 1);      var tablabel = $(this)         .removeclass("tab")         .attr("id", id)         .find("h3")         .remove()         .text();      // create corresponding tab link     tablinks.append("<li><a href=\"#" + id + "\">" + tablabel + "</a></li>");   });  $(".tabs")    .prepend(tablinks)    .tabs();


Comments

Post a Comment

Popular posts from this blog

linux - xterm copying to CLIPBOARD using copy-selection causes automatic updating of CLIPBOARD upon mouse selection -

i've tried various ways coerce xterm (versions 285 , 292) copy selection clipboard clipboard whenever press ctrl-shift-c. promising way far has been, in ~/.xresources, put this: xterm*vt100.translations: #override \ ctrl shift <keypress> c: copy-selection(clipboard) \n\ ctrl shift <keypress> v: insert-selection(clipboard) ctrl-shift-v works perfectly, copying has nuance... if restart xterm, highlighting text puts things in primary clipboard; expected, proper, default behavior. if hit ctrl-shift-c, copies current selection clipboard clipboard. the bug, however, if highlight text after first time pressed ctrl-shift-c, you'll see highlighting copies both primary and clipboard. cannot figure out how stop xterm updating clipboard upon selection... , doesn't make sense me in first place. i said, @ specific point in time, copy selection clipboard... yet starts updating automatically upon selection after doing once... anyone have workaround...
Read more

c++ - qgraphicsview horizontal scrolling always has a vertical delta -

Image
i've subclassed qgraphicsview custom canvas used in cad application. i've reimplemented qgraphicsview::wheelevent check keyboard modifiers control key and, if control key pressed, zoom. i'm trying implement horizontal scroll when user holds shift , uses wheel. the problem i'm having horizontal scrolling always scrolls 0.279. not huge problem, hugely annoying , points else being wrong. so, here questions: is right way implement horizontal scrolling? if not, is? how eliminate delta of 0.279? thanks in advance. code , sample output below void myview::zoom(int delta) { double factor = pow(1.2, delta/abs(delta)); this->scale(factor, factor); } void myview::scrollhorizontal(int level) { qpointf center = maptoscene(viewport()->rect().center()); qdebug() << "center: " << center.x() << ", " << center.y(); centeron(qpointf(center.x() - level, center.y())); } void myview::wheelevent(qwheeleve...
Read more