Java compare this class to that class for equality -


my assignment override method equals(). have few concerns using stack12<e> = (stack12<e>)o; , o instanceof stack12. wonder bad practice, how using that in for-loop feels little not right me.

is there way compare class other object? or compare method robust enough?

  public boolean equals(java.lang.object o){   if(o == this) return true;   if(o == null || !(o instanceof stack12)){      return false;   }    stack12<e> = (stack12<e>)o;   if(this.size != that.size || this.capacity != that.capacity ){      return false;   }   for(int = 0; < this.size; i++){      if( that.stack[i] != this.stack[i] ){         return false;      }   }   return true;  }

one caveat i'd add whenever override equals(...), want override hashcode(). agree seeing instanceof overused makes me worry code smell, think have no choice use instanceof in situation. casting generic type, may wrong, @ run-time, generics don't exist, may moot.

one potentially major issue see though you're using == in loop. if stack array uses objects, should use equals(...) inside loop. fact class generic suggests stack array hold objects, i'm not sure since don't see this.


Comments

Post a Comment

Popular posts from this blog

linux - xterm copying to CLIPBOARD using copy-selection causes automatic updating of CLIPBOARD upon mouse selection -

i've tried various ways coerce xterm (versions 285 , 292) copy selection clipboard clipboard whenever press ctrl-shift-c. promising way far has been, in ~/.xresources, put this: xterm*vt100.translations: #override \ ctrl shift <keypress> c: copy-selection(clipboard) \n\ ctrl shift <keypress> v: insert-selection(clipboard) ctrl-shift-v works perfectly, copying has nuance... if restart xterm, highlighting text puts things in primary clipboard; expected, proper, default behavior. if hit ctrl-shift-c, copies current selection clipboard clipboard. the bug, however, if highlight text after first time pressed ctrl-shift-c, you'll see highlighting copies both primary and clipboard. cannot figure out how stop xterm updating clipboard upon selection... , doesn't make sense me in first place. i said, @ specific point in time, copy selection clipboard... yet starts updating automatically upon selection after doing once... anyone have workaround...
Read more

c++ - qgraphicsview horizontal scrolling always has a vertical delta -

Image
i've subclassed qgraphicsview custom canvas used in cad application. i've reimplemented qgraphicsview::wheelevent check keyboard modifiers control key and, if control key pressed, zoom. i'm trying implement horizontal scroll when user holds shift , uses wheel. the problem i'm having horizontal scrolling always scrolls 0.279. not huge problem, hugely annoying , points else being wrong. so, here questions: is right way implement horizontal scrolling? if not, is? how eliminate delta of 0.279? thanks in advance. code , sample output below void myview::zoom(int delta) { double factor = pow(1.2, delta/abs(delta)); this->scale(factor, factor); } void myview::scrollhorizontal(int level) { qpointf center = maptoscene(viewport()->rect().center()); qdebug() << "center: " << center.x() << ", " << center.y(); centeron(qpointf(center.x() - level, center.y())); } void myview::wheelevent(qwheeleve...
Read more